Improve processing of Storyboard and XIB files

Description

The objective is to apply changes suggested in this document and this Trello card.

My comments to the document.

1. Info.plist changes.
The change sounds logical according to this article, but I wonder if this is a typical change or an issue with a single project only.
Please test if a default Obj-C application with SceneDelegate doesn't include `$(PRODUCT_MODULE_NAME).` prefix while the Swift app does include it.
Also, test if this applies to iOS, macOS apps or both.
If we find this feasible, we'll create a subtask here in JIRA to modify Info.plist.

2. Should "CustomModuleProvider" always contain the string "target"?
Did the absence of this attribute lead to a crash, or you suggest adding this just to match what Xcode generates?

4. Why is this change optional?
Did the project crash without specifying the module name there, or not?

Please make these changes to (2) - (4) yourself.
Either modify the source file I've shared, and we can deploy it for testing,
or let me know if you want access to the Converter solution.

 

P.S. Granted you access to . Please use a feature branch and pull request(s) as suggested in CONTRIBUTING.md.

Environment

None

Activity

Show:
Md. Ibrahim Hassan
June 3, 2020, 5:49 PM
Edited

I checked the code on Develop against my local code and it is merged.
Also, I checked with uploading the same test project to our website and it gives the proper results, consistent with the local code results.

Here is the diff with no difference.

Alex Petuschak
June 4, 2020, 9:57 AM

So, this looks like an issue with the processing of XIB files in the Advanced Project Converter.

Please specify steps to reproduce this in .

Alex Petuschak
June 22, 2020, 2:47 PM

Is there anything left on this issue?

We have postponed (1) in .

If all done, put this in review and delete the (merged) Git branch.

Md. Ibrahim Hassan
June 22, 2020, 3:11 PM

Except for the xibs not being processed, logged here.

Md. Ibrahim Hassan
July 1, 2020, 3:58 AM

Deleted the branch which had been merged, and have put this In Review

Assignee

Md. Ibrahim Hassan

Reporter

Alex Petuschak

Labels

None

Git Branch Name

None

GitHub Issue

None

Components

Fix versions

Priority

High
Configure